Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spectral_frame_conversion domain function #23

Open
Jan-Willem opened this issue Nov 6, 2024 · 0 comments
Open

spectral_frame_conversion domain function #23

Jan-Willem opened this issue Nov 6, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Jan-Willem
Copy link
Member

  • Add the function convert_spectral_frame to src/astroviper/_domain/_visibility.
  • The function should take in a single ms_xds and return an ms_xds where the Spectral reference frame has been converted to the specified output_reference_frame:
    • convert_spectral_reference_frame(ms_xds, output_reference_frame, ...)
  • Astropy should be used for the conversion.
  • NumPy docstring should be included.
  • Tests should be added to tests/domain/visibility.
  • Code should be formatted using Black.
@Jan-Willem Jan-Willem added the enhancement New feature or request label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants