Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation and simulations class #33

Open
GJHSimmons opened this issue Dec 4, 2023 · 0 comments
Open

Compilation and simulations class #33

GJHSimmons opened this issue Dec 4, 2023 · 0 comments
Labels
design Discussions around design decisions future features Description of planned functionality needs change This doesn't seem right

Comments

@GJHSimmons
Copy link
Collaborator

We discussed that the current system class currently plays two roles:

  1. Using data in a population, it creates a system of ODEs ready for numerical simulation.
  2. It creates a simulation according to given parameters (currently end_time, n_steps, mode).

These two functionalities should be separated out. The first should create a system object associated to a population (potentially compiled from an internal call of population, for example population.compile().

The second should create one or more simulation classes according to different simulation parameters. A container subclass simulations will then be created to hold multiple different simulations (which could either come from the same system or across systems). This class would contain functionality to compare the simulations it contains.

@GJHSimmons GJHSimmons added future features Description of planned functionality needs change This doesn't seem right design Discussions around design decisions labels Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Discussions around design decisions future features Description of planned functionality needs change This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant