Update casbin-orm-adapter model name #3
Conversation
|
|
|
@conghuhu plz fix:
|
|
@rushitote plz review |
There was a problem hiding this comment.
I am not sure if we should do it this way, because then the module will need to be imported by require("CasbinAdapter") - which is too general and doesn't specify what kind of adapter is this.
Instead we could rename the file to CasbinORMAdapter.lua for consistency, what do you think?
|
OK, then I will continue to use CasbinORMAdapter |
|
@rushitote if this is the case, actually we have another ORM adapter: https://github.com/casbin-lua/luasql-adapter , so
|
|
@hsluoyz |
|
@conghuhu plz use this name: |
I think it's better to modify this piece to be consistent with the examples
Fix: #2