Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we add v3~v5 field to the enforce function's arg? #43

Closed
jump2cn opened this issue Apr 21, 2023 · 2 comments · Fixed by #44
Closed

Can we add v3~v5 field to the enforce function's arg? #43

jump2cn opened this issue Apr 21, 2023 · 2 comments · Fixed by #44
Assignees
@hsluoyz
Labels
enhancement New feature or request

Comments

@jump2cn
Copy link
Contributor

jump2cn commented Apr 21, 2023

casdoor-python-sdk/src/casdoor/main.py

Line 271 in 03c20fe

"v2": act,

I need some more infomation for my rule model, then I added them into v3,v4. but for now, this code can only pass v0~v2.
are those args seems according by casdoor build-in default model or for other reasons ?
@casbin-bot
Copy link

@seriouszyx @ComradeProgrammer @Resulte

@casbin-bot casbin-bot added the enhancement New feature or request label Apr 21, 2023
@hsluoyz
Copy link
Member

hsluoyz commented Apr 21, 2023

@jump2cn hi, can you make a PR to add v3-v5 fields as optional args?

@jump2cn jump2cn mentioned this issue Apr 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsluoyz hsluoyz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add v3-v5 field into enforce function's arg.
3 participants
@jump2cn @hsluoyz @casbin-bot