Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing error when @Burst is on a test’s superclass #90

Open
squarejesse opened this issue Jan 23, 2025 · 0 comments
Open

Confusing error when @Burst is on a test’s superclass #90

squarejesse opened this issue Jan 23, 2025 · 0 comments

Comments

@squarejesse
Copy link
Collaborator

I’m seeing this failure building the subclass.

error: @Burst parameter must be a boolean, an enum, or have a burstValues() default value

There’s two problems:

  1. The compiler generates an overriding function (origin=FAKE_OVERRIDE) declared by the subtype
  2. That generated override maintains @Test but drops all the parameter defaults

This might be exacerbated by supertypes that have type parameters? I’m not completely sure.

We should probably detect Burst functions that are fake overrides, and strip the @Test from them. It’s annoying to have to do this because I would have preferred @Test to be stripped before the fake overrides were generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant