Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshots should be placed into src/{sourceSetName}/snapshots/ for MPP plugin #595

Open
JakeWharton opened this issue Oct 5, 2022 · 0 comments · May be fixed by #1649
Open

Snapshots should be placed into src/{sourceSetName}/snapshots/ for MPP plugin #595

JakeWharton opened this issue Oct 5, 2022 · 0 comments · May be fixed by #1649
Assignees
@jrodbx @geoff-powell
Labels
enhancement New feature or request
Milestone
2.0.0-alpha01

Comments

@JakeWharton
Copy link
Collaborator

Snapshots seem to be unconditionally placed in src/test/snapshots/. For Kotlin MPP, the name of the Android-specific source set is arbitrary and that name should be used as the source set folder so that the snapshots/ directly is placed relative to the tests which produced the snapshots.

You can see the undesired default behavior in action here: https://github.com/cashapp/redwood/tree/0f708ea3cdd950a427dde46547c4ce67ba01a60c/redwood-layout/src
@JakeWharton JakeWharton added the enhancement New feature or request label Oct 5, 2022
@jrodbx jrodbx added this to the 1.4 milestone May 31, 2023
@JakeWharton JakeWharton mentioned this issue Sep 22, 2023
Closed
This was referenced Sep 28, 2023
Closed
Merged
@jrodbx jrodbx self-assigned this Sep 28, 2023
jrodbx pushed a commit that referenced this issue Sep 28, 2023
Vary snapshot output dir based on applied kotlin plugin
cf453a0 
Closes #595
@jrodbx jrodbx mentioned this issue Sep 28, 2023
Closed
@jrodbx jrodbx modified the milestones: 1.3.2, 1.4 Sep 28, 2023
@jrodbx jrodbx mentioned this issue Mar 1, 2024
Merged
@geoff-powell geoff-powell linked a pull request Oct 21, 2024 that will close this issue
Open
@geoff-powell geoff-powell self-assigned this Oct 21, 2024
saket added a commit to saket/telephoto that referenced this issue Jan 1, 2025
@saket
Workaround cashapp/paparazzi#595
243b0fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrodbx jrodbx

@geoff-powell geoff-powell

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0.0-alpha01
Development

Successfully merging a pull request may close this issue.

Add support for snapshots for android multiplatform cashapp/paparazzi
3 participants
@JakeWharton @jrodbx @geoff-powell