Golden images in /build/paparazzi/failures
are not stored in some error cases
#1716
Labels
bug
Something isn't working
Milestone
I'm not sure if this should be classified as a bug of a feature request:
Description
Golden images are stored in
/build/paparazzi/failures
when there is a regression (next to thedelta-*.png
files) but, they are not when:The reference image (in
/test/snapshots/images
) is not present:The reference image has a different size:
Steps to Reproduce
I can create a simple project for that if it is really necessary, but I think the description is fairly simple, and easy to reproduce, without special setup. Please let me know.
Expected behavior
Having golden screenshots generated even when the test fail because it does not match the reference (or if the reference is missing) would be very valuable in CI scenarios, where the newly created golden images could be immediately extracted without having to run an entire pipeline with a new execution of
recordPaparazzi
Gradle task.Also, running the
recordPaparazzi
might lead to unrelated golden images being updated (with invisible variations) that would flood the review diff.Additional information:
Note:
In previous versions (pre-
OffByTwo
), when there was a regression with different image sizes, the delta and golden images were stored to disk on/out/failures
.The text was updated successfully, but these errors were encountered: