NUT11 sign outputs #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandlafbtc
approved these changes
Sep 19, 2024
Co-authored-by: gandlafbtc <[email protected]>
Co-authored-by: gandlafbtc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: this issue
Description
Adding support for signing the outputs when needed. This is a step towards
SIG_ALLimplementation and a fix for issues when trying to redeemSIG_ALLtokens on cashu.me and others that use cashu-ts behind the scenes. With this functionality we can then instruct cashu-ts to sign the outputs when it findsSIG_ALLtags.Changes
signBlindedMessage,getSignedOutput,getSignedOutputswitnessinBlindedMessagecreateRandomBlindedMessageandblindMessageto allow a private key to be specified as input and act accordingly.PR Tasks
npm run test--> no failing unit testsnpm run format