Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow multiple private keys when signing proofs #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow multiple private keys when signing proofs #5

wants to merge 1 commit into from

Conversation

gandlafbtc
Copy link
Collaborator

Fixes: cashubtc/cashu-ts#179

Description

Allow an array of private keys when signing proofs, matching with the pubkey in the secret

Changes

  • extended method signature to allow array
  • match keys if array is passed

PR Tasks

  • Open PR
  • run npm run test --> no failing unit tests
  • run npm run format

callebtc
callebtc approved these changes Sep 25, 2024
View reviewed changes
Copy link

@callebtc callebtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callebtc callebtc callebtc approved these changes

@Egge21M Egge21M Awaiting requested review from Egge21M

@minibits-cash minibits-cash Awaiting requested review from minibits-cash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

receive locked tokens to multiple different keys
2 participants
@gandlafbtc @callebtc