Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Deps #147

Closed
thesimplekid opened this issue May 29, 2024 · 2 comments · Fixed by #300
Closed

Bump Deps #147

thesimplekid opened this issue May 29, 2024 · 2 comments · Fixed by #300

Comments

@thesimplekid
Copy link
Collaborator

Once rust-lightning updates bitcoin it can be updated here.

lightningdevkit/rust-lightning#3063
@thesimplekid thesimplekid modified the milestone: V0.1 Jun 1, 2024
@thesimplekid
Copy link
Collaborator Author

thesimplekid commented Jun 6, 2024 •
edited
Loading

Once on the new version of bitcoin we can also use their re-export of base64 and remove it as a direct dep.

cdk/crates/cdk/Cargo.toml

Line 21 in 267e5f0

base64 = "0.22" # bitcoin uses v0.13 (optional dep)

@prusnak prusnak mentioned this issue Aug 20, 2024
Merged
@prusnak
Copy link
Contributor

prusnak commented Aug 20, 2024 •
edited
Loading

attempt to address this is in #300

@thesimplekid thesimplekid linked a pull request Aug 20, 2024 that will close this issue
chore: bump bitcoin + lightning-invoice deps #300
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bump bitcoin + lightning-invoice deps prusnak/cdk
2 participants
@prusnak @thesimplekid