Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong "realFee" #122

Closed
KKA11010 opened this issue Aug 13, 2023 · 0 comments · Fixed by #190 or #257
Closed

Wrong "realFee" #122

KKA11010 opened this issue Aug 13, 2023 · 0 comments · Fixed by #190 or #257
Assignees
@BilligsterUser
Labels
bug Something isn't working

Comments

@KKA11010
Copy link
Collaborator

KKA11010 commented Aug 13, 2023 •
edited
Loading

Describe the bug
When a user performs a Lightning transaction (melt or swap) and got not charged any fee (based on his balance afterwards), the key "realFee" still returns the same amount as the "estimated fees" that is determined before a Lightning transaction.

To Reproduce
Steps to reproduce the behavior:
0. Remember your balance before starting to reproduce.

  1. Go to 'dashboard' and press 'Send'.
  2. In the bottom popup, press on 'Pay Lightning invoice'.
  3. Optionally (multiple mints with balance available), choose a mint URL to perform melt/swap transaction from.
  4. Select any recipient option that fits best to you. (Does not matter, each one will reproduce the bug)
  5. Go through the steps provided by the UI until the invoice is paid by the mint.
  6. If payment is successfull, a "success screen" will be shown where a FEE amount is displayed (realFee).
  7. Fee is higher than 0 even if no fees have been payed.

Expected behavior
"realFee" should be the exact amount of fees that have been payed for a Lightning transaction. If payed 0 fee, then realFee has to be 0.

Additional context

  • Branch: UX
  • The code that is used to show the "realFee" in the success screen can be found here
  • The function that is used for melting is here and the code used in that function that calculates the realFee is here
@KKA11010 KKA11010 added the bug Something isn't working label Aug 13, 2023
KKA11010 pushed a commit that referenced this issue Sep 10, 2023
@BilligsterUser
fix #122
dcfb2ed 
#122
@KKA11010 KKA11010 mentioned this issue Sep 11, 2023
Merged
KKA11010 added a commit that referenced this issue Sep 13, 2023
@KKA11010 @BilligsterUser
Update the melting process (#190)
588046a 
* update error messages in the melting process #175

* fix melt via invoice scan, pass cashu err msg #175

* fix scan invoice check and process with +1 mint

* remove some logs

* update expo deps, fix melted amount rendering

* fix rendering of fees for a melting tx history

* fix #122

#122

* clean up

* deps

---------

Co-authored-by: BilligsterUser <[email protected]>
BilligsterUser added a commit that referenced this issue Nov 8, 2023
@BilligsterUser
fix #122
b3c0d66
KKA11010 pushed a commit that referenced this issue Nov 8, 2023
@BilligsterUser
fix #122 (#257)
ec0141d
@BilligsterUser BilligsterUser linked a pull request Nov 9, 2023 that will close this issue
fix #122 #257
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BilligsterUser BilligsterUser

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the melting process cashubtc/eNuts
fix #122 cashubtc/eNuts
2 participants
@KKA11010 @BilligsterUser