Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added type-safe i18next - fix minor spelling, styling and translation issues #113

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

KKA11010
Copy link
Collaborator

Fixes #97

@KKA11010 KKA11010 added bug Something isn't working DX Topics related to developer experience labels Jul 11, 2023
@KKA11010 KKA11010 added this to the First Beta Release milestone Jul 11, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 14.59% and project coverage change: +0.25 🎉

Comparison is base (0d8becd) 22.54% compared to head (05a56f4) 22.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   22.54%   22.80%   +0.25%     
==========================================
  Files          99      100       +1     
  Lines        3424     3451      +27     
  Branches      933      938       +5     
==========================================
+ Hits          772      787      +15     
- Misses       2587     2599      +12     
  Partials       65       65              
Impacted Files Coverage Δ
src/components/App.tsx 0.00% <0.00%> (ø)
src/components/Backup.tsx 0.00% <0.00%> (ø)
src/components/ErrorScreen/ErrorDetails.tsx 0.00% <0.00%> (ø)
src/components/InitialModal.tsx 0.00% <0.00%> (ø)
src/components/InvoiceAmount.tsx 0.00% <0.00%> (ø)
src/components/modal/OptsModal.tsx 0.00% <0.00%> (ø)
src/components/modal/Question.tsx 0.00% <0.00%> (ø)
src/components/modal/TrustMint.tsx 0.00% <0.00%> (ø)
src/components/nav/BottomNav.tsx 0.00% <0.00%> (ø)
src/components/nav/TopNav.tsx 0.00% <0.00%> (ø)
... and 37 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@BilligsterUser BilligsterUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫥

@BilligsterUser BilligsterUser merged commit 7c9a318 into main Jul 11, 2023
3 checks passed
@BilligsterUser BilligsterUser deleted the i18next branch July 11, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DX Topics related to developer experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18next Type-Safe Translations
3 participants