Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review #141

Merged
merged 46 commits into from
Aug 26, 2023
Merged

Review #141

merged 46 commits into from
Aug 26, 2023

Conversation

KKA11010
Copy link
Collaborator

@KKA11010 KKA11010 commented Aug 19, 2023

Fixes #126
Fixes #130
Fixes #131
Fixes #132
Fixes #133
Fixes #134
Fixes #128
Fixes #143
Fixes #135
Fixes #138

@swedishfrenchpress, kindly execute the branch and inform me about the resolution status of the mentioned issues based on your review.

@KKA11010 KKA11010 added enhancement New feature or request styling Layout related issue UX User experience related labels Aug 19, 2023
@KKA11010 KKA11010 self-assigned this Aug 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2023

Codecov Report

Patch coverage: 9.26% and project coverage change: -0.12% ⚠️

Comparison is base (cfc20e0) 15.32% compared to head (3fa5881) 15.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   15.32%   15.20%   -0.12%     
==========================================
  Files         137      139       +2     
  Lines        4345     4445     +100     
  Branches     1172     1205      +33     
==========================================
+ Hits          666      676      +10     
- Misses       3600     3686      +86     
- Partials       79       83       +4     
Files Changed Coverage Δ
src/components/App.tsx 0.00% <0.00%> (ø)
src/components/Button.tsx 4.00% <0.00%> (+4.00%) ⬆️
src/components/Empty.tsx 0.00% <0.00%> (ø)
src/components/Icons.tsx 2.59% <0.00%> (-6.19%) ⬇️
src/components/InputAndLabel.tsx 0.00% <0.00%> (ø)
src/components/Logo.tsx 100.00% <ø> (ø)
src/components/QR.tsx 0.00% <ø> (ø)
src/components/Toaster.tsx 0.00% <ø> (ø)
src/components/modal/index.tsx 0.00% <ø> (ø)
src/components/nav/BottomNav.tsx 0.00% <0.00%> (ø)
... and 56 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KKA11010 KKA11010 marked this pull request as draft August 19, 2023 20:52
@swedishfrenchpress
Copy link
Collaborator

@KKA11010 Is the intent to display the onboarding screens before prompting the user for their pin? For what it's worth, I believe it's best to present them before asking for the pin.

@KKA11010
Copy link
Collaborator Author

@KKA11010 Is the intent to display the onboarding screens before prompting the user for their pin? For what it's worth, I believe it's best to present them before asking for the pin.

Ok I did not think much about it but it sounds good to show them before asking for pin. 👍

@KKA11010
Copy link
Collaborator Author

@KKA11010 Is the intent to display the onboarding screens before prompting the user for their pin? For what it's worth, I believe it's best to present them before asking for the pin.

done

@KKA11010 KKA11010 marked this pull request as ready for review August 26, 2023 16:51
@KKA11010 KKA11010 merged commit ab295a6 into main Aug 26, 2023
3 checks passed
@KKA11010 KKA11010 deleted the review branch August 26, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment