Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check and reset nostr data popup #265

Merged
merged 5 commits into from
Nov 21, 2023
Merged

check and reset nostr data popup #265

merged 5 commits into from
Nov 21, 2023

Conversation

KKA11010
Copy link
Collaborator

@KKA11010 KKA11010 commented Nov 19, 2023

This PR adds the following changes:

  • deduplicate contacts entries before rendering
  • add a initial popup to reset nostr data for users encountering crash
  • add a contacts option in the settings to reset nostr data

Reset nostr data should fix the issue causing the app to crash after navigating to "contacts"

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2023

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (04f6018) 13.94% compared to head (f7f78f3) 13.87%.

Files Patch % Lines
src/screens/Dashboard.tsx 0.00% 19 Missing ⚠️
src/screens/Settings/Contacts.tsx 0.00% 9 Missing ⚠️
src/components/Icons.tsx 0.00% 6 Missing ⚠️
src/screens/Settings/index.tsx 0.00% 6 Missing ⚠️
src/components/modal/Prompt.tsx 0.00% 2 Missing ⚠️
src/components/nav/BottomNav.tsx 0.00% 1 Missing ⚠️
src/screens/Addressbook/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
- Coverage   13.94%   13.87%   -0.08%     
==========================================
  Files         159      159              
  Lines        5672     5702      +30     
  Branches     1549     1554       +5     
==========================================
  Hits          791      791              
- Misses       4736     4766      +30     
  Partials      145      145              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KKA11010 KKA11010 merged commit 9679a39 into main Nov 21, 2023
5 checks passed
@KKA11010 KKA11010 deleted the crash branch November 21, 2023 12:19
@KKA11010 KKA11010 changed the title use uniqByIContacts in onContactsChanged event check and reset nostr data popup Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants