Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed recovery 🌱 #300

Merged
merged 80 commits into from
Feb 8, 2024
Merged

Seed recovery 🌱 #300

merged 80 commits into from
Feb 8, 2024

Conversation

KKA11010
Copy link
Collaborator

@KKA11010 KKA11010 commented Feb 4, 2024

Description

This PR includes changes to support the restore method provided by the cashu-ts library. I introduce this as an optional feature in eNuts with room for improvements. Most of the additions are related to the frontend and translations.

Any reviews or feedback you can provide would be very helpful!

Please take note of the following files that have been added/modified and require attention:

  • src/wallet/index.ts > diff
  • src/storage/store/restore.ts > diff
  • src/components/hooks/Restore.tsx > diff

Fixes #140

Changes

  • ✔️ Upgraded cashu-ts to version 0.9.0
  • ✔️ Implemented a counter for each keysetId, which increments with each valid proof received. See counter
  • ✔️ Using wallet.restore(start, count, keysetId?) in a recursive manner. See restore hook and recursive function
  • The parameter keysetId of wallet.restore(start, count, keysetId?) is currently not used!
  • ✔️ Introducing several new screens including landing, mnemonic, recovery, hints & recommendations, and more... fully translated in 6 languages (GPT4)

photo_2024-02-06_14-43-12

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

Attention: 507 lines in your changes are missing coverage. Please review.

Comparison is base (d503c80) 13.47% compared to head (02691e5) 13.21%.

Files Patch % Lines
src/wallet/index.ts 11.70% 70 Missing and 13 partials ⚠️
src/components/hooks/Restore.tsx 0.00% 66 Missing ⚠️
src/screens/Restore/SelectRecoveryMint.tsx 0.00% 55 Missing ⚠️
src/screens/Restore/Seed.tsx 0.00% 48 Missing ⚠️
src/screens/Restore/ConfirmMnemonic.tsx 0.00% 37 Missing ⚠️
src/screens/Restore/Mnemonic.tsx 0.00% 26 Missing ⚠️
src/screens/History/Details.tsx 0.00% 23 Missing ⚠️
src/screens/Restore/Recover.tsx 0.00% 22 Missing ⚠️
src/components/Icons.tsx 0.00% 15 Missing ⚠️
src/screens/Auth/index.tsx 0.00% 14 Missing ⚠️
... and 19 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
- Coverage   13.47%   13.21%   -0.27%     
==========================================
  Files         162      167       +5     
  Lines        5893     6169     +276     
  Branches     1624     1685      +61     
==========================================
+ Hits          794      815      +21     
- Misses       4954     5208     +254     
- Partials      145      146       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KKA11010 KKA11010 marked this pull request as ready for review February 6, 2024 15:33
Copy link
Collaborator

@onoomobo onoomobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a PR for the fixed GPT errors.

@KKA11010 KKA11010 merged commit e717541 into main Feb 8, 2024
5 checks passed
@KKA11010 KKA11010 deleted the cashuts branch February 8, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seed phrase backup
4 participants