Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add onRequestClose prop to Modal #79

Merged
merged 1 commit into from
Jun 22, 2023
Merged

add onRequestClose prop to Modal #79

merged 1 commit into from
Jun 22, 2023

Conversation

KKA11010
Copy link
Collaborator

No description provided.

@KKA11010 KKA11010 added the enhancement New feature or request label Jun 22, 2023
@KKA11010 KKA11010 added this to the First Beta Release milestone Jun 22, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 6.66% and project coverage change: -0.04 ⚠️

Comparison is base (e397c6a) 23.10% compared to head (fa40ee3) 23.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##              fix      #79      +/-   ##
==========================================
- Coverage   23.10%   23.07%   -0.04%     
==========================================
  Files          85       85              
  Lines        3008     3012       +4     
  Branches      811      811              
==========================================
  Hits          695      695              
- Misses       2248     2252       +4     
  Partials       65       65              
Impacted Files Coverage Δ
src/components/App.tsx 0.00% <0.00%> (ø)
src/components/InitialModal.tsx 0.00% <ø> (ø)
src/components/modal/OptsModal.tsx 0.00% <ø> (ø)
src/components/modal/Question.tsx 0.00% <ø> (ø)
src/components/modal/TrustMint.tsx 0.00% <ø> (ø)
src/components/modal/index.tsx 56.52% <ø> (ø)
src/components/screens/Addressbook/Contact.tsx 0.00% <0.00%> (ø)
src/components/screens/Addressbook/modal.tsx 0.00% <ø> (ø)
src/components/screens/History/Details.tsx 0.00% <0.00%> (ø)
src/components/screens/Lightning/modal.tsx 0.00% <0.00%> (ø)
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KKA11010 KKA11010 merged commit 4e91ef8 into fix Jun 22, 2023
3 checks passed
@KKA11010 KKA11010 deleted the modal branch June 22, 2023 17:54
BilligsterUser pushed a commit that referenced this pull request Jun 22, 2023
* run dep:update

* small styling fix

* update new contact state

* update after review

* add onRequestClose prop to Modal (#79)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants