Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mint] Check "already signed" output for blank outputs in /melt #526

Open
callebtc opened this issue May 7, 2024 · 0 comments
Open

[Mint] Check "already signed" output for blank outputs in /melt #526

callebtc opened this issue May 7, 2024 · 0 comments
Assignees
Labels
bug Something isn't working mint About the Nutshell mint

Comments

@callebtc
Copy link
Collaborator

callebtc commented May 7, 2024

We check whether outputs have already been signed for a /swap and /mint but not for the change outputs for a /melt.

Edit: checking already signed outputs might not be enough since two requests with the same outputs can both turn out to be unsigned yet but still cause a race condition. A real fix needs a lock on the outputs like we do it for pending proofs.

@callebtc callebtc added bug Something isn't working mint About the Nutshell mint labels May 7, 2024
@callebtc callebtc self-assigned this May 7, 2024
@callebtc callebtc changed the title [Mint] Check duplicate output for blank outputs in /melt [Mint] Check "already signed" output for blank outputs in /melt May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mint About the Nutshell mint
Projects
None yet
Development

No branches or pull requests

1 participant