Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet: determine valid amounts from mint's keys response #618

Open
callebtc opened this issue Sep 11, 2024 · 0 comments
Open

Wallet: determine valid amounts from mint's keys response #618

callebtc opened this issue Sep 11, 2024 · 0 comments
Labels
bug Something isn't working good first issue A great way to get into Cashu development wallet About the Nutshell wallet

Comments

@callebtc
Copy link
Collaborator

Currently, the wallet assumes that the mint will use amounts in 2^n. This is not necessarily true, as the mint could use any amount decomposition they like (which is fine according to the protocol).

The wallet should not make use of settings.max_order but infer this from the keys it has received from the mint. An example line in wallet.py that needs to be fixed is:

allowed_amounts = [2**i for i in range(settings.max_order)]
@callebtc callebtc added bug Something isn't working wallet About the Nutshell wallet good first issue A great way to get into Cashu development labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue A great way to get into Cashu development wallet About the Nutshell wallet
Projects
None yet
Development

No branches or pull requests

1 participant