Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mint: Remember NUT-08 outputs in melt quote and reissue overspent lightning fees on startup check #621

Open
callebtc opened this issue Sep 18, 2024 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed mint About the Nutshell mint

Comments

@callebtc
Copy link
Collaborator

callebtc commented Sep 18, 2024

We should persist the NUT-08 outputs in the melt_quote db before attempting a lightning payment with pay_invoice so that an eventual later payment state check (for example in ledger._check_pending_proofs_and_melt_quotes) that turns out to be PAID can issue change and return that in a MeltQuoteResponse.

Right now we do not reissue overpaid fees if the melt quote is settled outside of the melt() method.

@callebtc callebtc added bug Something isn't working help wanted Extra attention is needed mint About the Nutshell mint labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed mint About the Nutshell mint
Projects
None yet
Development

No branches or pull requests

1 participant