Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mint: Limits and balance views per keyset #650

Open
callebtc opened this issue Oct 28, 2024 · 2 comments
Open

Mint: Limits and balance views per keyset #650

callebtc opened this issue Oct 28, 2024 · 2 comments

Comments

@callebtc
Copy link
Collaborator

Limit amounts (max_balance, max_mint, max_melt) all assume the sat unit and do not work well for a multi-unit mint. We would have to add limits per each supported unit or come up with a better configuration. Checks should be refactored so they're not repeated in the code.

The balance views in the db should show issued vs redeemed = balance views for each keyset in the mint instead of a total cumulative balance that doesn't reflect reality for a multi-unit mint.

@lollerfirst
Copy link
Contributor

Should new migrations be created for this or do we modify the existing ones create_balance_views etc...

@lollerfirst
Copy link
Contributor

I think we can get away with just modifying the create_balance_views function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants