-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make superset dashboard improvements for user testing #3867
Comments
For the welcome dashboard, we want to:
The flow for welcome dashboard improvements:
We can divide these sections up by using tabs. |
Ugh, some very frustrating findings while trying to iron out the permissions for user test. When you give a user permission to a datasource, it gives them read access to all the datasets, charts and dashboards that are derived from the datasource including ones made by other users :/ This poses some UX and privacy concerns for us. I wrote up a discussion in the superset repo about this issue. UX: If users can see everything built off PUDL it will get difficult to navigate the UI. You can filter dashboards and charts by owner. We could tell users to filter for charts owned by themselves and an admin account that is responsible for creating all the default PUDL charts and dashboards. Superset does expose a way to restrict the owners that appear in the filter dropdowns however I don't think it actually restricts the dashboards and charts you see when the lists are unfiltered. Privacy: all users' first and last names will be available to anyone who registers. Users won't be able to publish dashboards and keep them private. Solutions?
|
Hmm, this is unfortunate. How do larger organizations deal with this? Letting everybody see everything all the time seems like chaos? Only providing access to dashboards seems like we'd be hiding a lot of functionality -- not the functionality we want the CSV folks to see maybe, but still a lot of power and flexibility I think we'd been hoping to expose for folks that want it. It would also mean that we'd only be able to roll out access piecemeal, as we build out appropriate dashboards that eventually come to cover all of PUDL. My intuition is that it's probably best to make it clear that this is all publicly visible, and do our best to use the UI, tagging, or whatever other organizational tools are available to us to provide direction to the best resources. Getting into the guts of the Superset code to make it do something we want that's different feels like a recipe for madness. Separately, I've wondered whether we might be able to offer public access -- with everything you create being visible to everyone else -- as the free option, and then offer the ability to create private dashboards, saved queries, maybe access to other non-PUDL data? etc. as a paid option. |
Even more separately, I've also been wondering whether there's an extremely simple way that we could provide an in-browser interface that can be pointed at the URL of a Parquet file in S3, display its metadata, and provide a barebones GUI in the vein of Datasette for folks to build a As an added benefit... this would make every publicly visible Parquet file on the internet accessible to CSV users... which would also include all the datasets at Hugging Face, and a bunch of other stuff in the AWS Open Data Registry. Some suggestions from the Hive Mind included: |
tl;dr: I think we can make our users live with this permissions thing; we can also try to build our own thing for "download a CSV" use case, and see if that's better than trying to hack it into Superset. I think "just live with it" is probably OK... we can tell people not to publish things unless they want to have them be public.
I think that makes sense - it really seems like Superset isn't really designed for this important use case of "download the data so you can use it with Excel." I'm imagining some sort of frontend-only interface that lives alongside our data dictionary, which lets people preview/filter/download, or click on a link to make custom dashboards/visualizations in Superset. This would let us stop fighting with Superset to get the "download data" use case, and just let it be what it was meant to be: a data viz and exploration tool. We also wouldn't have to programmatically create dashboards for every table we want people to be able to filter, and so maybe people won't have as much of a reliance on Superset dashboards, making this permissions thing less of a problem. |
Given that we're on the cusp of actually testing out this tool, I'd like to just ask our users how they feel about this and whether it's a dealbreaker for them when we do the tests, rather than assuming it will be. I don't think mocking up another option is a bad idea at all, but I would like to wait until we see how people respond to our current set-up. |
Yeah, agree that we should do any additional frontend stuff after the first user calls! |
I'm moving the remaining bonus items to #3908 and closing this. Everything absolutely crucial to address prior to user testing has been addressed. |
Before we do user testing we need to make a few improvements. We'll check in on this work after 5 hours.
High Priority
Bonus
The text was updated successfully, but these errors were encountered: