Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get_number_of_channels #391

Open
h-mayorquin opened this issue Feb 21, 2025 · 0 comments
Open

Remove get_number_of_channels #391

h-mayorquin opened this issue Feb 21, 2025 · 0 comments

Comments

@h-mayorquin
Copy link
Collaborator

Follow up on:
#386

Now that we no longer have a channel as an argument of get_frames and we are sticking to the one extractor per channel argument I don't think it makes sense to have the get_number_of_channels method:

@abstractmethod
def get_num_channels(self) -> int:
"""Get the total number of active channels in the recording.
Returns
-------
num_channels: int
Integer count of number of channels.
"""
pass

I think we should remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant