Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated dev version and changelog #381

Merged
merged 4 commits into from
Nov 15, 2024
Merged

updated dev version and changelog #381

merged 4 commits into from
Nov 15, 2024

Conversation

pauladkisson
Copy link
Member

Post Release PR.

@pauladkisson pauladkisson enabled auto-merge (squash) November 13, 2024 18:14
Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a date?

setup.py Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@pauladkisson
Copy link
Member Author

@h-mayorquin, pls don't approve one of my PRs and then request changes in the comments. It's a pet-peeve of mine, and it can cause problems with auto-merge. For example, if all the tests pass and auto-merge is on, and you approve the PR, it will merge and close, and then I would have to open another PR to implement any feedback.

So pls, if you are requesting changes on a PR, don't approve the PR until I've actually implemented the changes.

@h-mayorquin
Copy link
Collaborator

We need some better language. If I approve, that mean that all the other things are suggestions if I feel very strong about something I would use the request button.

How would you like me to communicate this? Check here for guidelines in bigger projects:
https://scikit-learn.org/dev/developers/contributing.html#communication-guidelines

I do really like making suggestions that are not requestions or just discuss in PRs so just let me know do you prefer me to do that.

@pauladkisson
Copy link
Member Author

We need some better language. If I approve, that mean that all the other things are suggestions if I feel very strong about something I would use the request button.

How would you like me to communicate this? Check here for guidelines in bigger projects: https://scikit-learn.org/dev/developers/contributing.html#communication-guidelines

I do really like making suggestions that are not requestions or just discuss in PRs so just let me know do you prefer me to do that.

How about if you want to just make suggestions, you can select the "comment" option. Then, you can expect me to either implement each suggestion or respond explaining why I don't want to, and once I've worked through all the comments I'll re-request your review. If your satisfied with my changes/responses, you can approve the PR at that point. If you want to continue the discussion we can do a back-and-forth until we reach agreement, and you can approve the PR at that point.

Would that work with your system?

@pauladkisson pauladkisson merged commit 1702faf into main Nov 15, 2024
29 checks passed
@pauladkisson pauladkisson deleted the post_release branch November 15, 2024 16:55
@h-mayorquin
Copy link
Collaborator

Yeah, Paul, we are not that many, I can follow that policy when I interact with you. No comments after approval is a rule I can remember ; )

@pauladkisson
Copy link
Member Author

Thanks for humoring me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants