Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some icons appear to be missing or not using the new icons. #7

Closed
michael-farwell opened this issue Nov 1, 2023 · 10 comments
Closed
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@michael-farwell
Copy link

I've notice that the python icon is still using the default icon. And the Vue and poetry.lock icons are not showing at all.
Screenshot 2023-11-01 at 6 24 30 AM
Screenshot 2023-11-01 at 6 24 36 AM
Screenshot 2023-11-01 at 6 24 45 AM

This is in Pycharm Professional 2023.2.3

@quentinguidee quentinguidee added the bug Something isn't working label Nov 1, 2023
@quentinguidee
Copy link
Member

quentinguidee commented Nov 1, 2023

Thank you for the issue! I can reproduce this.

  • For the Vue Icon, this is an .ext missing in catppuccin/vscode-icons, I'll update that today
  • For the poetry.lock it doesn't seem that catppuccin/vscode-icons has an icons for this at the momemt. They solves this because they detect with VSCode that the language is Toml, then use the Tool icon instead, but it should definitely be a custom icon.
  • For Python however, that's strange as everything seems defined correctly. I suspect that our plugin is loaded before the Python plugin from JetBrains, and so the Python plugin replaces our icon. I'll check that

@michael-farwell
Copy link
Author

Not sure if this helps, but the python icon is changed in the tab of the opened file.
Screenshot 2023-11-02 at 7 19 19 AM

@quentinguidee
Copy link
Member

Really strange 😅 thanks for this info!

I won't be able to check this issue before this weekend, but it's one of the most important icons so I'll look at it as soon as possible

@CodingRuo
Copy link

Hey! Ich have the same Problem with the .vue Files.

image image

any Idea?

@quentinguidee
Copy link
Member

Yep, .vue are also mentioned in the OP comment!

I looked at this issue yesterday, and I think it will be harder to solve than expected. The solution seems to remove entirely the icon from the tree and replace it by a custom one, instead of patching the current ones. That's caused by some plugins who force their own icons.

If someone can look at this that would be really cool, but I will not have the time in the coming days.

@ricardoboss
Copy link

@quentinguidee just what you suggested, I hope: catppuccin/vscode-icons#63

@quentinguidee
Copy link
Member

Thanks! This should be updated with b0072e5.

@sgoudham Could you already release that as a patch? As this icon seems to be highly requested

@ricardoboss
Copy link

To add to this list: .razor icons also don't work:
image

@quentinguidee
Copy link
Member

Since many icons seem to be missing, I'll close this issue in favor of #14 that I'll pin to the repo, so we can have a summary of the missing icons. If some icons are not in the table, don't hesitate to comment!

@quentinguidee quentinguidee closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2023
@quentinguidee
Copy link
Member

quentinguidee commented Jan 2, 2024

@ricardoboss @CodingRuo @michael-farwell .vue should be fixed with the 1.1.0 that just released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants