-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(menu): add menu style options #247
Conversation
To allow `#{thm_x}` styling of menus. - @catppuccin_menu_style (`menu-style`) - @catppuccin_menu_selected_style (`menu-selected-style`) - @catppuccin_menu_border_style (`menu-border-style`)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change has some unintended side effects:
- does not work with transparency
This can be fixed by usingbg=default
instead ofbg=${thm_gray}
(maybe also only setting fg have not tested that). - disabled options are no longer grayed out.
Don't know how to fix this only other menu option I can find ismenu-border-lines
(https://github.com/tmux/tmux/blob/master/options-table.c#L332-L366).
Maybe default to""
and only set when not""
?
Thanks, @vdbe. I'll test those defaults more carefully, and update the pull request. |
@vdbe: Switching to This is with tmux 3.4 installed from nixos-unstable, and configured with catppuccin/nix. |
Weird can you try it with just |
I had mouse enabled. Thanks for the flake. That helped me reproduce the problem. I still don't totally understand why the disabled items were losing styling under that basic config, and not my own, but it was solely related to changing the Based on testing with your flake as you showed, this looks good to me now. |
To allow
#{thm_x}
styling of menus.menu-style
)menu-selected-style
)menu-border-style
)