working multiprocessing #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontrol_window_length as input
…ontrol_window_length as input
…s in the multi-threading, now using a determinisitc version
|
I tested the branch on various benchmarking dataset, also comparing envp-mode to non-envp. Everything looks good in the results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim: Allow multiprocessing for the window building (b2w). This is especially interesting for ultra-high-coverage samples.
In master branch, the windows are build one-by-one through a for-loop.
countervariable is updated with the potentially extended window length. Probably this could be done in advance before the iteration over the window, one would need to keep the orginal window length and the extended one. So this lines would to be moved before: https://github.com/LaraFuhrmann/VILOCA/blob/6835ab15f8b0f1a0b4dd32687414555bce0475ca/shorah/b2w.py#L147