Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved overdispersion calculation #25

Merged
merged 12 commits into from
Nov 15, 2024
Merged

moved overdispersion calculation #25

merged 12 commits into from
Nov 15, 2024

Conversation

dr-david
Copy link
Collaborator

@dr-david dr-david commented Nov 15, 2024

This PR resolves #22.

@pawel-czyz pawel-czyz added the refactor Changes refactoring the code label Nov 15, 2024
@pawel-czyz pawel-czyz linked an issue Nov 15, 2024 that may be closed by this pull request
3 tasks
@pawel-czyz
Copy link
Member

Nice! I think we should first merge #26, and then slightly expand this PR to resolve issue #22.

One thing I'm wondering about: this code is whether the shapes are right: as described in #24, we use both the conventions (n_timepoints, n_variants) and its transpose, (n_variants, n_timepoints) in various places.

@pawel-czyz pawel-czyz merged commit c612716 into main Nov 15, 2024
1 check passed
@pawel-czyz pawel-czyz deleted the move_overdispersion branch November 15, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes refactoring the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove covvfit._frequentist submodule
2 participants