Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selected_streams optional argument #3

Open
abcsds opened this issue Feb 20, 2022 · 2 comments
Open

Add selected_streams optional argument #3

abcsds opened this issue Feb 20, 2022 · 2 comments

Comments

@abcsds
Copy link
Contributor

abcsds commented Feb 20, 2022

I'd suggest to add an optional argument to the read_xdf function that receives either a list of integers with the desired streams ids, or a list of strings with the stream names. What do you think is best? both?

@abcsds abcsds changed the title Add selected_streams variable. Add selected_streams optional argument Feb 20, 2022
@cbrnr
Copy link
Owner

cbrnr commented Feb 21, 2022

Stream names do not need to be unique, so I think it should be a list of stream IDs.

@cbrnr
Copy link
Owner

cbrnr commented Feb 21, 2022

BTW, the parameter is called select_streams in pyxdf.load_xdf and stream_ids in a wrapper function that I have written for MNELAB. Maybe it would be a good idea to reuse one of these names?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants