Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do the integration specs work on all build environments? #57

Closed
cburgmer opened this issue Mar 29, 2014 · 2 comments
Closed

Do the integration specs work on all build environments? #57

cburgmer opened this issue Mar 29, 2014 · 2 comments

Comments

@cburgmer
Copy link
Owner

Had a report that the integration tests are failing on a different Mac OSX system. This could be connected to slightly different images being generated and the diffing not being generous enough.

Also currently we don't display the diff as we are using our own diffing method workaround as we are not happy with the current tolerance implementation on imagediff (HumbleSoftware/js-imagediff#18).

@cburgmer
Copy link
Owner Author

Commit e92e436 fixes a few issues with Firefox 26 on a Ubuntu system.

Using the v1.1 branch from imagediff seems to stop the jasmine without further notice, might be an issue there?

@cburgmer
Copy link
Owner Author

Also tested on a Windows machine. Looking good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant