Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [FTB Chunks] Turtles bypass FTB Claims #115

Open
Merith-TK opened this issue Jul 12, 2022 · 2 comments
Open

[Bug] [FTB Chunks] Turtles bypass FTB Claims #115

Merith-TK opened this issue Jul 12, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@Merith-TK
Copy link
Collaborator

Merith-TK commented Jul 12, 2022

Useful information to include:

  • Minecraft version, 1.18.2, 1.19
  • CC: Restitched, latest
  • Logs: N/A

Turtles are able to bypass FTB Chunks land claims

@Merith-TK Merith-TK added the bug Something isn't working label Jul 12, 2022
@SquidDev
Copy link
Member

SquidDev commented Jul 22, 2022

We currently do permission checks using two systems:

  • MinecraftServer.isUnderSpawnProtection
  • Patbox's Common Permission API

FTB-Chunks however listens to Fabric API's block events, which we don't fire. We should fire those too (probably worth just copying from CC:T here).

It would be nice if FTB-Chunks also mixed-in into isUnderSpawnProtection, might be worth suggesting on their issue tracker.

@Merith-TK
Copy link
Collaborator Author

FTB-Chunks however listens to Fabric API's block events, which we don't fire. We should fire those too (probably worth just copying from CC:T here).

if you could possibly fix that, I would be most grateful

You are basically the first person since I discovered this (and informed people about) to look into it to my knowledge despite the severity since #114 is caused basically directly by this to my knowledge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants