You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This means that monitor data is now sent too early, before IP has sent BlockEntitys. Thus, when the client receives the monitor data, it has no monitors to associate it with, and discards them, resulting in black monitors when chunks are loaded.
There's a couple of fixes I can see here:
Hook into IP's NewChunkTrackingGraph.beginWatchChunkSignal event and also call MonitorWatcher.onWatch when that "signal" is fired. This isn't an official API, so has no stability guarantees.
Add an event to Fabric API for chunk watching/unwatching. Then update CC:R to listen to this event and submit a MR to IP to fire it in their own chunk watching code. Obviously this has a much longer turn around time.
I'm going to file this issue on IP's side too, given that they're the Problem Mod here, and see if they have any suggestions.
The text was updated successfully, but these errors were encountered:
Useful information to include:
Immersive Portals overwrites the
ChunkMap.playerLoadedChunk
method, deferring sending the chunk data until later on:https://github.com/qouteall/ImmersivePortalsMod/blob/6f512afb56d1ff0835b30a7a8eaf65b0043e84e7/imm_ptl_core/src/main/java/qouteall/imm_ptl/core/mixin/common/chunk_sync/MixinChunkMap_C.java#L111-L116
This means that monitor data is now sent too early, before IP has sent
BlockEntity
s. Thus, when the client receives the monitor data, it has no monitors to associate it with, and discards them, resulting in black monitors when chunks are loaded.There's a couple of fixes I can see here:
Hook into IP's
NewChunkTrackingGraph.beginWatchChunkSignal
event and also callMonitorWatcher.onWatch
when that "signal" is fired. This isn't an official API, so has no stability guarantees.Add an event to Fabric API for chunk watching/unwatching. Then update CC:R to listen to this event and submit a MR to IP to fire it in their own chunk watching code. Obviously this has a much longer turn around time.
I'm going to file this issue on IP's side too, given that they're the Problem Mod here, and see if they have any suggestions.
The text was updated successfully, but these errors were encountered: