Add multi-card and proration to readme #351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-for-multi-pin-and-multi-card-aggregations
|
@wagnerlmichael I think you're right, this has a lot of overlap with stuff already in the README. I'm going to close this for this repo, but I think it's worth resurrecting as a wiki issue. IMO, this should really include diagrams and examples, as it's card to grok the full complexity of multi-card/proration interaction until you draw it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new section to the readme which contains our strategy for multi-card and prorated parcel values. I didn't add a diagram because I think it's possible the textual description is clear enough, but I'd like to hear others' thoughts. If anything I think the proration would benefit more from a diagram.
It seems like there is a significant amount of overlap with the post-modeling section. I wonder if we should just put multi-card and proration in that section.
Thoughts? @dfsnow