Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add require global #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mathieudutour
Copy link
Contributor

fix #16

@ccgus
Copy link
Owner

ccgus commented Jan 26, 2018

This patch looks OK, but there's over 127 changes in it, and I bet there only needs to be less than 10.

Looks like there's over 100 changes where whitespace was deleted, can you change those back to what they were previously so there's not as much noise in the patch?

And it looks like for all the new code double spacing was used, where everywhere else uses four spaces for indentation. I can fix that on my end with a copy and paste w/ Xcode's auto-indent easily if you don't beat me to it though.

@InvisiblePixels InvisiblePixels deleted the f/require-global branch April 11, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CommonJS and npm integration
2 participants