From c14cd34a31194957e67da1e1b46efe77458c0532 Mon Sep 17 00:00:00 2001
From: nk-coding <niklask.coding@gmail.com>
Date: Tue, 6 Aug 2024 15:21:04 +0200
Subject: [PATCH] use absolute redirect URLs

---
 backend/src/api-internal/auth-error-redirect.middleware.ts   | 5 ++---
 backend/src/api-internal/auth-redirect.middleware.ts         | 2 +-
 backend/src/api-oauth/oauth-authorize-redirect.middleware.ts | 3 ++-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/backend/src/api-internal/auth-error-redirect.middleware.ts b/backend/src/api-internal/auth-error-redirect.middleware.ts
index 42898d46..23024b51 100644
--- a/backend/src/api-internal/auth-error-redirect.middleware.ts
+++ b/backend/src/api-internal/auth-error-redirect.middleware.ts
@@ -38,9 +38,8 @@ export class AuthErrorRedirectMiddleware extends StateMiddleware<OAuthAuthorizeS
                 ? "register-additional"
                 : "login";
             const encodedState = encodeURIComponent(this.stateJwtService.sign({ request: state.request }));
-            res.redirect(
-                `/auth/flow/${target}?error=${encodeURIComponent(error.authErrorMessage)}&strategy_instance=${encodeURIComponent(error.strategyInstanceId)}&state=${encodedState}`,
-            );
+            const url = `/auth/flow/${target}?error=${encodeURIComponent(error.authErrorMessage)}&strategy_instance=${encodeURIComponent(error.strategyInstanceId)}&state=${encodedState}`;
+            res.redirect(new URL(url, process.env.GROPIUS_ENDPOINT).toString());
         } else {
             next();
         }
diff --git a/backend/src/api-internal/auth-redirect.middleware.ts b/backend/src/api-internal/auth-redirect.middleware.ts
index 6ad845aa..59e29629 100644
--- a/backend/src/api-internal/auth-redirect.middleware.ts
+++ b/backend/src/api-internal/auth-redirect.middleware.ts
@@ -166,7 +166,7 @@ export class AuthRedirectMiddleware extends StateMiddleware<
                     suggestions.displayName ?? "",
                 )}&forceSuggestedUsername=${state.strategy.forceSuggestedUsername}`;
                 const url = `/auth/flow/register?code=${token}&state=${encodedState}` + suggestionQuery;
-                res.redirect(url);
+                res.redirect(new URL(url, process.env.GROPIUS_ENDPOINT).toString());
             } else {
                 await this.redirectWithCode(state, res);
             }
diff --git a/backend/src/api-oauth/oauth-authorize-redirect.middleware.ts b/backend/src/api-oauth/oauth-authorize-redirect.middleware.ts
index 7986f26e..7c7d8e97 100644
--- a/backend/src/api-oauth/oauth-authorize-redirect.middleware.ts
+++ b/backend/src/api-oauth/oauth-authorize-redirect.middleware.ts
@@ -27,6 +27,7 @@ export class OAuthAuthorizeRedirectMiddleware extends StateMiddleware<
             ? "register-additional"
             : "login";
         const encodedState = encodeURIComponent(this.stateJwtService.sign({ request: state.request }));
-        res.redirect(`/auth/flow/${target}?state=${encodedState}`);
+        const url = `/auth/flow/${target}?state=${encodedState}`;
+        res.redirect(new URL(url, process.env.GROPIUS_ENDPOINT).toString());
     }
 }