Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Resolve deprecated react-sticky problem #819

Closed
nikolas opened this issue Sep 18, 2020 · 1 comment
Closed

Resolve deprecated react-sticky problem #819

nikolas opened this issue Sep 18, 2020 · 1 comment
Assignees
@nbuonin

Comments

@nikolas
Copy link
Member

nikolas commented Sep 18, 2020

react-sticky is causing a deprecation error:

Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

See: captivationsoftware/react-sticky#292 (comment)

We either patch react-sticky ourselves, take over maintenance, or switch to another method of achieving this. I implemented this in Mediathread using just position: sticky; CSS.
@nbuonin
Copy link
Contributor

nbuonin commented Oct 30, 2020

Resolved by #879

@nbuonin nbuonin closed this as completed Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nbuonin nbuonin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikolas @nbuonin