Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 issue when uploading to GitHub Pages, due to error in node modules (maybe add node_modules to .gitignore file?) #20

Open
TommyJackson85 opened this issue May 21, 2018 · 0 comments

Comments

@TommyJackson85
Copy link

TommyJackson85 commented May 21, 2018

When I try to upload the project to GitHub Pages, I get a 404 error when loading the index file, followed by an email from GitHub:

The page build failed for the master branch with the following error:
The variable {{a} on line 50 in node_modules/balanced-match/README.md was not properly closed with }}. For more information, see https://help.github.com/articles/page-build-failed-tag-not-properly-terminated/.
For information on troubleshooting Jekyll see:
https://help.github.com/articles/troubleshooting-jekyll-builds
If you have any questions you can contact us by replying to this email

I managed to fix this error after reading up on the following links. This is a common problem with Jekyll:
juliangruber/balanced-match#22
EarthlingInteractive/aframe-geo-projection-component@f06ab2e

I fixed the error by changing the .gitignore file to the following, (BEFORE uploading it as a new repository to GitHub):

node_modules/*
.idea/

may I suggest changing the .gitignore file, or to highlight this issue in the ES6-Tutorial instructions, incase someone else wants to upload it to GitHub pages.
edit: If the repository is already uploaded with node_modules you could untrack node_modules with the following git command at the repository folder:
git rm --cached node_modules -r

TommyJackson85 added a commit to TommyJackson85/google-maps that referenced this issue May 21, 2018
an error in node_modules was causing a 404 issue when uploading it to
GitHub pages. So I removed node modules from the repository. (I also
changed the gitignore document to ignore node_modules when uploading
again.) I highlight this issue more from the original repository I
used:  ccoenraets/es6-tutorial#20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant