We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Our polygon masking code rejects polygons with 3 or less vertices.
dxtbx/src/dxtbx/masking/masking.h
Lines 120 to 122 in 9e26747
It makes sense to reject cases with one vertex (i.e. point) or two vertices (i.e. line) but why do we reject triangles?
Changing this to
DXTBX_ASSERT(polygon.size() >= 3);
seems working but am I missing some corner cases?
The text was updated successfully, but these errors were encountered:
Perhaps this was always meant to be >=? I can't think of any reason to reject a triangle
>=
Sorry, something went wrong.
Allow triangles in polygon masking (fixes cctbx#757)
a2208dc
Allow triangles in polygon masking (fixes #757)
374dcea
@dagewa Thanks for confirmation. I made a pull request.
No branches or pull requests
Our polygon masking code rejects polygons with 3 or less vertices.
dxtbx/src/dxtbx/masking/masking.h
Lines 120 to 122 in 9e26747
It makes sense to reject cases with one vertex (i.e. point) or two vertices (i.e. line) but why do we reject triangles?
Changing this to
DXTBX_ASSERT(polygon.size() >= 3);
seems working but am I missing some corner cases?
The text was updated successfully, but these errors were encountered: