Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration #28

Open
kw217 opened this issue Mar 31, 2021 · 4 comments
Open

Registration #28

kw217 opened this issue Mar 31, 2021 · 4 comments

Comments

@kw217
Copy link
Contributor

kw217 commented Mar 31, 2021

This app is currently a bit unreliable on my spa, and I think it's because we are trying to use the same channel as the panel unit.

I'm thinking of adding registration to the app (in client.rb), using the logic in https://github.com/rsrawley/spaControl/blob/master/spa.js#L283 . Does that sound OK, and has anyone attempted this already?

@bggardner
Copy link
Collaborator

I've done it in Python, following the Channel Assignment protocol. Not sure what @rsrawley is doing with the "default" preferredChannel: "11", but the channel should only be supplied by the Main Board (not assumed or hard-coded).

@ccutrer
Copy link
Owner

ccutrer commented Apr 1, 2021

Oh wow, I hadn't even seen all that channel assignment stuff in the wiki. Yes, definitely I'd be happy to merge it if you write it (and I'll try it out with my spa).

@rsrawley
Copy link

rsrawley commented Apr 1, 2021

If I recall correctly, I believe my intention with preferredChannel was to avoid increasing the assigned channel by one every time I ran my code when testing. I still need to fix the case when the spa loses power and restarts, as my program does not check if its assigned channel is still active. At the moment, I have to restart the program if I restart the spa.

@kw217
Copy link
Contributor Author

kw217 commented Apr 1, 2021

@rsrawley I don't have that issue, because I have it running on a Pi powered off the Balboa main board - so if the spa loses power so does the program. I'll see if I can do something about that case.

@ccutrer cool, thanks - I'll see what I can do :-) I have a few days off over the weekend, if I have a following wind I should get to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants