Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Empty charge_distributions in QuickExact-Simulation #667

Open
contra-bit opened this issue Feb 13, 2025 · 11 comments
Open

🐛 Empty charge_distributions in QuickExact-Simulation #667

contra-bit opened this issue Feb 13, 2025 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@contra-bit
Copy link

fiction version

0.6.8

OS

Ubuntu 24.10

Python version

3.12.7

C++ compiler

g++ (Ubuntu 14.2.0-4ubuntu2) 14.2.0

Additional environment information

I have activated the virtual environment (.venv) using uv before running the notebook. I would appreciate any help in resolving this issue.

Please let me know if you need any further information or if there's anything else I can provide to help resolve this issue. @Drewniok

Description

I am experiencing an issue with the "sidb_gate_designs_and_analysis" notebook from the repository https://github.com/cda-tum/mnt-sidb-technology-demo. The "charge_distributions" of the QuickExact-Simulation are empty.

I am using the following versions:

  • pyfiction: mnt-pyfiction==0.6.8
  • Python: 3.12.7
  • uv: 0.4.30

Expected behavior

Expected result: The "charge_distributions" of the QuickExact-Simulation should not be empty.

Actual result: The "charge_distributions" of the QuickExact-Simulation are empty.

Image

How to Reproduce

Steps to reproduce:

  1. Clone the repository https://github.com/cda-tum/mnt-sidb-technology-demo
  2. Activate the virtual environment (.venv)
  3. Run the "sidb_gate_designs_and_analysis" notebook
@contra-bit contra-bit added the bug Something isn't working label Feb 13, 2025
@contra-bit
Copy link
Author

I have also tried installing pyfiction from the master branch

@Drewniok Drewniok assigned Drewniok and wlambooy and unassigned marcelwa Feb 13, 2025
@Drewniok
Copy link
Collaborator

Drewniok commented Feb 13, 2025

Hi @contra-bit,

Thank you for your detailed bug report. We are looking into it and come back to you as soon as possible.

@wlambooy
Copy link
Collaborator

wlambooy commented Feb 13, 2025

Hi @contra-bit, I cannot reproduce the issue on Ubuntu 24.04 running the commands in a Python interpreter (3.13.0) after installing the bindings with uv (version 0.5.31).

Can you tell me: does the ground state for input 00 show up like it should?

@wlambooy
Copy link
Collaborator

Image

wlambooy added a commit that referenced this issue Feb 13, 2025
@contra-bit
Copy link
Author

Image

AFAIK no since it crashes before.

Image

@contra-bit
Copy link
Author

I have checkout your test branch and run the tests with nox. I have lots of test failures.

log2.txt

@contra-bit
Copy link
Author

Also for some strange reason lots of more tests failed before i ran sudo apt install libtinyxml2-dev, which is strange since tinyxm2 is vendored
in libs

log.txt

@wlambooy
Copy link
Collaborator

I have checkout your test branch and run the tests with nox. I have lots of test failures.

log2.txt

What branch is that?

@wlambooy
Copy link
Collaborator

Also for some strange reason lots of more tests failed before i ran sudo apt install libtinyxml2-dev, which is strange since tinyxm2 is vendored in libs

log.txt

I'm getting this too locally. We're not sure what causes it.

@contra-bit
Copy link
Author

I have checkout your test branch and run the tests with nox. I have lots of test failures.
log2.txt

What branch is that?
I checkout the branch for the PR with this trick:

git fetch origin pull/668/head:pr-668    
git checkout pr-668

These are the only two commits which where added:

commit 93e23767f1508b69ded8578cfdb630891eb122a4 (HEAD -> pr-668)
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Thu Feb 13 14:50:37 2025 +0000

    🎨 Incorporated pre-commit fixes

commit bf1c28bd5c0f4de5391a5f810b812975c26de480
Author: wlambooy <[email protected]>
Date:   Thu Feb 13 15:47:19 2025 +0100

    :snake: Added test for issue #667

@contra-bit
Copy link
Author

🤔 Do these tests fail only for me? 🤷‍♂️

  • 📝 bindings/mnt/pyfiction/test/algorithms/physical_design/test_design_sidb_gates.py:
    • ❌ TestDesignSiDBGates::test_nor_gate_111
    • ❌ TestDesignSiDBGates::test_nor_gate_111_quickcell
    • ❌ TestDesignSiDBGates::test_siqad_and_gate_skeleton_100
  • 📊 bindings/mnt/pyfiction/test/algorithms/simulation/sidb/test_can_positive_charges_occur.py:
    • ❌ TestCanPositiveChargesOccur::test_three_DBs_100_lattice
    • ❌ TestCanPositiveChargesOccur::test_three_DBs_111_lattice
  • 📈 bindings/mnt/pyfiction/test/algorithms/simulation/sidb/test_critical_temperature.py:
    • ❌ TestCriticalTemperature::test_bestagon_inv
    • ❌ TestCriticalTemperature::test_perturber_and_DB_pair_100
    • ❌ TestCriticalTemperature::test_perturber_and_DB_pair_111
  • 🔄 bindings/mnt/pyfiction/test/algorithms/simulation/sidb/test_exhaustive_ground_state_simulation.py:
    • ❌ TestExhaustiveGroundStateSimulation::test_perturber_and_sidb_pair
    • ❌ TestExhaustiveGroundStateSimulation::test_perturber_and_sidb_pair_111
  • 📊 bindings/mnt/pyfiction/test/algorithms/simulation/sidb/test_is_ground_state.py:
    • ❌ TestIsGroundState::test_three_DBs_100_lattice
    • ❌ TestIsGroundState::test_three_DBs_111_lattice
  • 🤖 bindings/mnt/pyfiction/test/algorithms/simulation/sidb/test_is_operational.py:
    • ❌ TestIsOperational::test_and_gate_111_lattice_11_input_pattern
    • ❌ TestIsOperational::test_and_gate_111_lattice_operational_input_pattern
    • ❌ TestIsOperational::test_and_gate_kinks
    • ❌ TestIsOperational::test_and_gate_non_operational_due_to_kinks
    • ❌ TestIsOperational::test_and_gate_non_operational_input_patterns_due_to_kinks
    • ❌ TestIsOperational::test_is_operational
  • 📈 bindings/mnt/pyfiction/test/algorithms/simulation/sidb/test_operational_domain.py:
    • ❌ TestOperationalDomain::test_and_gate_111_lattice
    • ❌ TestOperationalDomain::test_critical_temperature_domain_xor_gate_100_lattice
    • ❌ TestOperationalDomain::test_xor_gate_100_lattice
  • 📊 bindings/mnt/pyfiction/test/algorithms/simulation/sidb/test_operational_domain_ratio.py:
    • ❌ TestComputeOperationalRatioAtPoint::test_and_gate_100_lattice
  • 📊 bindings/mnt/pyfiction/test/algorithms/simulation/sidb/test_physical_population_stability.py:
    • ❌ TestAssessPhysicalPopulationStability::test_three_DBs_100_lattice
    • ❌ TestAssessPhysicalPopulationStability::test_three_DBs_111_lattice
  • 🔄 bindings/mnt/pyfiction/test/algorithms/simulation/sidb/test_quickexact.py:
    • ❌ TestQuickExact::test_perturber_and_sidb_pair_111
  • 🔄 bindings/mnt/pyfiction/test/algorithms/simulation/sidb/test_quicksim.py:
    • ❌ TestQuicksim::test_perturber_and_sidb_pair
    • ❌ TestQuicksim::test_perturber_and_sidb_pair_111
  • 📝 bindings/mnt/pyfiction/test/technology/test_charge_distribution_surface.py:
    • ❌ TestChargeDistributionSurface::test_initialization_111_lattice
  • 📊 bindings/mnt/pyfiction/test/technology/test_sidb_nm_distance.py:
    • ❌ TestSiDBNmDistance::test_sidb_nm_distance_100_lattice
    • ❌ TestSiDBNmDistance::test_sidb_nm_distance_111_lattice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants