Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wsgi_intercept.STRICT_RESPONSE_HEADERS as a flag #178

Open
cdent opened this issue Oct 2, 2016 · 2 comments
Open

add wsgi_intercept.STRICT_RESPONSE_HEADERS as a flag #178

cdent opened this issue Oct 2, 2016 · 2 comments

Comments

@cdent
Copy link
Owner

cdent commented Oct 2, 2016

Add a flag to build_tests that allows turning wsgi_intercept.STRICT_RESPONSE_HEADERS on and in the wsgi intercept context manager fixture.

The challenge here is getting the flag value to the fixture.

Also the number of parameters on build_tests is getting absurd. It's time to explore some new models.

/cc @jd

@jd
Copy link
Contributor

jd commented Oct 3, 2016

What struck me when I took a look at that, is more the global variable that is provided by wsgi_intercept. That might be the first thing to change.

@cdent
Copy link
Owner Author

cdent commented Oct 3, 2016

@FND and I talked about that in IRC some time last week and it was basically what I said to you: The use of a global is because of the multiple entry points into wsgi-intercept's big mess, which will be a large effort to fix.

We can hide that complexity in gabbi (without regard to the implementation being what it is now or how it changes later) now, with something like this flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants