fix more lints

Signed-off-by: Carlos Panato <[email protected]>

Author: cpanato

docs/README.md

@@ -97,7 +97,7 @@ To see the event, let's render it as JSON and log it:
 
 ```golang
 // Render the event as JSON
-eventJson, err := cdevents.AsJsonString(event)
+eventJson, err := cdevents.AsJSONString(event)
 examples.PanicOnError(err, "failed to marshal the CDEvent")
 fmt.Printf("%s", eventJson)
 ```
@@ -219,15 +219,15 @@ In this case we know that the event is in the v0.4 version format, so we use the
 ```golang
 // Load, unmarshal and validate the event
 eventBytes, err := os.ReadFile("changecreated.json")
-event, err := cdevents04.NewFromJsonBytes(eventBytes)
+event, err := cdevents04.NewFromJSONBytes(eventBytes)
 
 err = cdevent.Validate(event)
 if err != nil {
 	log.Fatalf("cannot validate event %v: %v", event, err)
 }
 
 // Print the event
-eventJson, err := cdevents.AsJsonString(event)
+eventJson, err := cdevents.AsJSONString(event)
 examples.PanicOnError(err, "failed to marshal the CDEvent")
 fmt.Printf("%s\n\n", eventJson)
 ```

docs/examples/custom/main.go

@@ -12,7 +12,7 @@ import (
 	cloudevents "github.com/cloudevents/sdk-go/v2"
 )
 
-const customSchemaUri = "https://myregistry.dev/schemas/cdevents/quota-exceeded/0_1_0"
+const customSchemaURI = "https://myregistry.dev/schemas/cdevents/quota-exceeded/0_1_0"
 
 type Quota struct {
 	User      string `json:"user"`      // The use the quota applies ot
@@ -54,18 +54,18 @@ func main() {
 
 	// Set the required subject fields
 	event.SetSubjectContent(quotaRule123)
-	event.SetSchemaUri(customSchemaUri)
+	event.SetSchemaUri(customSchemaURI)
 
 	// Print the event
-	eventJson, err := cdevents.AsJsonString(event)
+	eventJSON, err := cdevents.AsJSONString(event)
 	examples.PanicOnError(err, "failed to marshal the CDEvent")
-	fmt.Printf("%s", eventJson)
+	fmt.Printf("%s", eventJSON)
 
 	// To validate the event, we need to load its custom schema
 	customSchema, err := os.ReadFile("myregistry-quotaexceeded_schema.json")
 	examples.PanicOnError(err, "cannot load schema file")
 
-	err = cdevents.LoadJsonSchema(customSchemaUri, customSchema)
+	err = cdevents.LoadJsonSchema(customSchemaURI, customSchema)
 	examples.PanicOnError(err, "cannot load the custom schema file")
 
 	ce, err = cdevents.AsCloudEvent(event)

docs/examples/schemauri/main.go

@@ -30,23 +30,23 @@ func main() {
 
 	// Unmarshal the schema to extract the $id. The $id can also be hardcoded as a const
 	eventAux := &struct {
-		Id string `json:"$id"`
+		ID string `json:"$id"`
 	}{}
 	err = json.Unmarshal(customSchema, eventAux)
 	examples.PanicOnError(err, "cannot get $id from schema file")
-	err = cdevents.LoadJsonSchema(eventAux.Id, customSchema)
+	err = cdevents.LoadJsonSchema(eventAux.ID, customSchema)
 	examples.PanicOnError(err, "cannot load the custom schema file")
 
 	// Load and unmarshal the event
 	eventBytes, err := os.ReadFile("changecreated.json")
 	examples.PanicOnError(err, "cannot load event file")
-	event, err := cdevents04.NewFromJsonBytes(eventBytes)
+	event, err := cdevents04.NewFromJSONBytes(eventBytes)
 	examples.PanicOnError(err, "failed to unmarshal the CDEvent")
 
 	// Print the event
-	eventJson, err := cdevents.AsJsonString(event)
+	eventJSON, err := cdevents.AsJSONString(event)
 	examples.PanicOnError(err, "failed to marshal the CDEvent")
-	fmt.Printf("%s\n\n", eventJson)
+	fmt.Printf("%s\n\n", eventJSON)
 
 	ce, err = cdevents.AsCloudEvent(event)
 	examples.PanicOnError(err, "failed to create cloudevent")

docs/examples/shared.go

@@ -8,7 +8,7 @@ import (
 // Copied from https://github.com/eswdd/go-smee/blob/33b0bac1f1ef3abef04c518ddf7552b04edbadd2/smee.go#L54C1-L67C2
 func CreateSmeeChannel() (*string, error) {
 	httpClient := http.Client{
-		CheckRedirect: func(req *http.Request, via []*http.Request) error {
+		CheckRedirect: func(_ *http.Request, _ []*http.Request) error {
 			return http.ErrUseLastResponse
 		},
 	}
@@ -24,6 +24,5 @@ func CreateSmeeChannel() (*string, error) {
 func PanicOnError(e error, message string) {
 	if e != nil {
 		log.Fatalf(message+", %v", e)
-		panic(e)
 	}
 }

pkg/api/bindings.go

@@ -31,21 +31,21 @@ import (
 )
 
 const (
-	SCHEMA_ID_REGEX   = `^https://cdevents.dev/([0-9]\.[0-9])\.[0-9]/schema/([^ ]*)$`
+	SchemaIDRegex     = `^https://cdevents.dev/([0-9]\.[0-9])\.[0-9]/schema/([^ ]*)$`
 	CustomEventMapKey = "custom"
 )
 
 var (
 	// Validation helper as singleton
 	validate              *validator.Validate
-	CDEventsSchemaIdRegex = regexp.MustCompile(SCHEMA_ID_REGEX)
+	CDEventsSchemaIDRegex = regexp.MustCompile(SchemaIDRegex)
 )
 
 func init() {
 	// Register custom validators
 	validate = validator.New()
 	validate.RegisterStructValidation(ValidateEventType, CDEventType{})
-	err := validate.RegisterValidation("uri-reference", ValidateUriReference)
+	err := validate.RegisterValidation("uri-reference", ValidateURIReference)
 	panicOnError(err)
 	err = validate.RegisterValidation("purl", ValidatePurl)
 	panicOnError(err)
@@ -84,7 +84,7 @@ func ValidateEventType(sl validator.StructLevel) {
 	}
 }
 
-func ValidateUriReference(fl validator.FieldLevel) bool {
+func ValidateURIReference(fl validator.FieldLevel) bool {
 	_, err := url.Parse(fl.Field().String())
 	return err == nil
 }
@@ -119,8 +119,8 @@ func AsCloudEvent(event CDEventReader) (*cloudevents.Event, error) {
 	return &ce, err
 }
 
-// AsJsonBytes renders a CDEvent as a JSON string
-func AsJsonBytes(event CDEventReader) ([]byte, error) {
+// AsJSONBytes renders a CDEvent as a JSON string
+func AsJSONBytes(event CDEventReader) ([]byte, error) {
 	if event == nil {
 		return nil, nil
 	}
@@ -131,9 +131,9 @@ func AsJsonBytes(event CDEventReader) ([]byte, error) {
 	return jsonBytes, nil
 }
 
-// AsJsonString renders a CDEvent as a JSON string
-func AsJsonString(event CDEventReader) (string, error) {
-	jsonBytes, err := AsJsonBytes(event)
+// AsJSONString renders a CDEvent as a JSON string
+func AsJSONString(event CDEventReader) (string, error) {
+	jsonBytes, err := AsJSONBytes(event)
 	if err != nil {
 		return "", err
 	}
@@ -147,7 +147,7 @@ func Validate(event CDEventReader) error {
 		return err
 	}
 	var v interface{}
-	jsonString, err := AsJsonString(event)
+	jsonString, err := AsJSONString(event)
 	if err != nil {
 		return fmt.Errorf("cannot render the event %s as json %w", event, err)
 	}
@@ -181,11 +181,11 @@ func Validate(event CDEventReader) error {
 	return nil
 }
 
-// NewFromJsonBytesContext[ContextType] builds a new CDEventReader from a JSON string as []bytes
+// NewFromJSONBytesContext[ContextType] builds a new CDEventReader from a JSON string as []bytes
 // This works by unmarshalling the context first, extracting the event type and using
 // that to unmarshal the rest of the event into the correct object.
 // `ContextType` defines the type of Context that can be used to unmarshal the event.
-func NewFromJsonBytesContext[CDEventType CDEvent](event []byte, cdeventsMap map[string]CDEventType) (CDEventType, error) {
+func NewFromJSONBytesContext[CDEventType CDEvent](event []byte, cdeventsMap map[string]CDEventType) (CDEventType, error) {
 	eventAux := &struct {
 		Context Context `json:"context"`
 	}{}