Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update JChemPaint to CDK 2.9 (or better) #11

Open
Tracked by #4
egonw opened this issue Jan 2, 2024 · 4 comments
Open
Tracked by #4

update JChemPaint to CDK 2.9 (or better) #11

egonw opened this issue Jan 2, 2024 · 4 comments
Labels
WP2

Comments

@egonw
Copy link
Member

egonw commented Jan 2, 2024

@egonw egonw added the WP2 label Jan 2, 2024
@egonw egonw mentioned this issue Jan 2, 2024
Open
9 tasks
@egonw
Copy link
Member Author

egonw commented Mar 10, 2024

No GitHub Actions are set up yet.

@egonw egonw mentioned this issue Mar 10, 2024
Closed
@egonw
Copy link
Member Author

egonw commented Jun 11, 2024

It currently uses CDK 2.0: https://github.com/JChemPaint/jchempaint/blob/master/pom.xml#L18

@RvdPloeg
Copy link
Collaborator

Code modifications were necessary to accept cdk-2.9 because it implements an IRGroup interface. After the modifications the program runs, see JChemPaint/jchempaint#196.

@egonw
Copy link
Member Author

egonw commented Dec 15, 2024

There is a note that the PR needs a revision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
WP2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@egonw @RvdPloeg