Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

var_and_units_pattern (re.Pattern) as a modifiable attribute #55

Open
FObersteiner opened this issue Feb 22, 2022 · 2 comments
Open

var_and_units_pattern (re.Pattern) as a modifiable attribute #55

FObersteiner opened this issue Feb 22, 2022 · 2 comments

Comments

@FObersteiner
Copy link
Contributor

this is a follow-up to #45

I'd like to implement var_and_units_pattern as an attribute with a @setter so I can modify it after creating the na file object with openNAFile.

This involves changes to na_core.py - I'd like to accompany the modification with some minor refactoring.
@FObersteiner FObersteiner mentioned this issue Feb 22, 2022
Merged
5 tasks
@FObersteiner FObersteiner changed the title var_and_units_pattern as a modifiable regex pattern var_and_units_pattern (re.Pattern) as a modifiable attribute Feb 22, 2022
@agstephens
Copy link
Member

@FObersteiner I have merged PR #56. Can we close this now?

@FObersteiner
Copy link
Contributor Author

yes, thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agstephens @FObersteiner