Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResponsiveMasonry #128

Open
SarkorbekA opened this issue Jul 30, 2024 · 6 comments
Open

ResponsiveMasonry #128

SarkorbekA opened this issue Jul 30, 2024 · 6 comments

Comments

@SarkorbekA
Copy link

image
i can't understand, what is the problem?
image

@chintanw3nuts
Copy link

Same here

@rusith
Copy link

rusith commented Aug 4, 2024

image

This happens because using defineProperty with only a getter makes it immutable. I think this is an issue with the build system.

I tried to build the code using v21.7.1 and it produces a different output. I am not sure which version the code authors used.

@rusith
Copy link

rusith commented Aug 4, 2024

I had to build it myself using the latest node version. hope this gets fixed soon (build using a latest node version
import from the lib folder)

@MNITD
Copy link

MNITD commented Sep 10, 2024

My team had this issue after regenerating the package-lock.json file during updating unrelated dependency

Our workaround is to downgrade to v2.2.0 and make it strict in package.json

terminal:

package.json:

- "react-responsive-masonry": "^2.2.0",
+ "react-responsive-masonry": "2.2.0",

@AndreyMarchuk
Copy link

same issue, v2.2.1 works without issues

@ADTC
Copy link

ADTC commented Nov 19, 2024

Regardless of the above, I wonder why a ResponsiveMasonry wrapper component is necessary when the Masonry component itself could be coded to accept a breakpoint object or breakpoint array instead of a number for columnCount (or as another prop) and simply make itself responsive based on it. 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants