Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables with unicode values fail to be serialized correctly #266

Open
thedrow opened this issue Mar 13, 2019 · 1 comment
Open

Tables with unicode values fail to be serialized correctly #266

thedrow opened this issue Mar 13, 2019 · 1 comment

Comments

@thedrow
Copy link
Member

thedrow commented Mar 13, 2019

On Python 2 the following dictionary:

{'': '\x80'}

is deserialized as:

{'': '\xc2\x80'}

That's incorrect and we should find a way to fix it.

The problem is the fact that '\x80' is a byte string but it is not specified as such. It should not be encoded to a unicode string.
On Python 3, this is fixed because unicode is fixed.

@thedrow
Copy link
Member Author

thedrow commented Apr 2, 2019

This is a very low priority issue.
If it's not fixed before py-amqp 5.0 we will close it as we're dropping Python 2.7 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant