Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

share/shwap: Getter: GetSharesByNamespace -> GetNamespaceData #3892

Closed
Wondertan opened this issue Oct 28, 2024 · 0 comments · Fixed by #3902
Closed

share/shwap: Getter: GetSharesByNamespace -> GetNamespaceData #3892

Wondertan opened this issue Oct 28, 2024 · 0 comments · Fixed by #3902
Assignees
@cristaloleg
Labels
kind:refactor Attached to refactoring PRs

Comments

@Wondertan
Copy link
Member

GetSharesByNamespace is an old name referring to the old data structure. Now that the structure is named NamespaceData we should refactor it accordingly. In the the interface and in the API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cristaloleg cristaloleg

Labels
kind:refactor Attached to refactoring PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

!refactor: rename GetSharesByNamespace to GetNamespaceData celestiaorg/celestia-node
2 participants
@cristaloleg @Wondertan