Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI jobs out of Ganache #11145

Open
Tracked by #11098
arthurgousset opened this issue Jul 17, 2024 · 0 comments
Open
Tracked by #11098

Migrate CI jobs out of Ganache #11145

arthurgousset opened this issue Jul 17, 2024 · 0 comments

Comments

@arthurgousset
Copy link
Contributor

arthurgousset commented Jul 17, 2024

Advice from Volpe

Consider removing/turning off the script that starts ganache, and see what breaks.

# in packages/protocol
$ yarn test

We use Ganache on CI to also verify that storage doesn't break. Create an inventory of workflows and dependencies on Ganache.

There are some ganache unit tests (FeeHandlerSeller) that need to be migrated to Foundry, that's a good first issue.
Can also remove migration.ts once those are migrated to anvil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants