Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UsingRegistry patter #11151

Open
martinvol opened this issue Jul 18, 2024 · 0 comments
Open

Remove UsingRegistry patter #11151

martinvol opened this issue Jul 18, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@martinvol
Copy link
Contributor

martinvol commented Jul 18, 2024 •
edited
Loading

Expected Behavior

Contracts should not change bytecode when a new contract is added to the reigstry. UsingRegistry or UsingRegistryV2 should be moved to mixins or it's own contract (not abstract).

Current Behavior

Many contracts currently inherit UsingRegistry or UsingRegistryV2 as a helper. When a new function or contract is created in these contracts, all children contract's bytecode change, and then get scheduled for releasing. This leads to confusion and big, unnecessary governance proposals.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martinvol @lvpeschke