Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types.Header marshaling using rlpgen #145

Closed
piersy opened this issue Jun 14, 2024 · 2 comments
Closed

Add types.Header marshaling using rlpgen #145

piersy opened this issue Jun 14, 2024 · 2 comments
Assignees

Comments

@piersy
Copy link

piersy commented Jun 14, 2024

Previously rlpgen was used to generate faster rlp encoding methods for types.Header (Approx 40% faster). When updating to support data migrated from Celo we dropped the use of the generated code, but we should consider adding it back for the two header structures we support.

@palango
Copy link
Collaborator

palango commented Dec 10, 2024

@Kourin1996 this is fixed with #288, right?

@Kourin1996
Copy link

@palango I think so. This issue should be same with https://github.com/celo-org/celo-blockchain-planning/issues/720.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants