Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check FeeHandler address in prestate tracing #216

Open
karlb opened this issue Sep 11, 2024 · 1 comment
Open

Check FeeHandler address in prestate tracing #216

karlb opened this issue Sep 11, 2024 · 1 comment

Comments

@karlb
Copy link

karlb commented Sep 11, 2024

Right now that address is ignored in prestate traces for non-fee-currency txs no lookupAccount is called on the FeeHandler address. A similar thing is true for OptimismBaseFeeRecipient for non-Cel2 Optimism chains.

Most likely solution:

  • lookupAccount(FeeHandlerAddress) for Cel2, lookupAccount(OptimismBaseFeeRecipient) for Optimism
  • Run most tracing tests with !Cel2 && !Optimism, so that we don't get different tracing results for the usual test cases (Ethereum burns the base fee, so it is expected that the base fee recipient address does not show up).
  • Add a new test case for Optimism and/or Cel2

See also https://discord.com/channels/1244729134312198194/1282997447609552986

@karlb
Copy link
Author

karlb commented Oct 21, 2024

Upstream PR to handle the generic OP-stack case: ethereum-optimism#407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants